[VSBC] Support for multiple legend selection for Vertical Stacked Bar Chart #33466
+89
−38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊 Bundle size report✅ No changes found |
|
Pull request demo site: URL |
fabricteam
reviewed
Dec 13, 2024
change/@fluentui-react-charting-891c4db7-8af3-489e-80f8-b8a02b227536.json
Show resolved
Hide resolved
srmukher
force-pushed
the
users/srmukher/legendsMultiSelectVBC
branch
from
796309f to
5ede767
Compare
srmukher
force-pushed
the
users/srmukher/legendsMultiSelectVBC
branch
from
5ede767 to
0235b7f
Compare
srmukher
force-pushed
the
users/srmukher/legendsMultiSelectVBC
branch
from
0e57dba to
cdde37e
Compare
…sers/srmukher/legendsMultiSelectVBC
….com/microsoft/fluentui into users/srmukher/legendsMultiSelectVBC
AtishayMsft
reviewed
Dec 20, 2024
...harts/react-charting/src/components/VerticalStackedBarChart/VerticalStackedBarChart.base.tsx
Outdated
Show resolved
Hide resolved
srmukher
force-pushed
the
users/srmukher/legendsMultiSelectVBC
branch
from
395c027 to
2c55a79
Compare
srmukher
changed the title
….com/microsoft/fluentui into users/srmukher/legendsMultiSelectVBC
…sers/srmukher/legendsMultiSelectVBC
AtishayMsft
reviewed
Dec 25, 2024
| @@ -140,8 +141,8 @@ export class VerticalStackedBarChartBase | |||
|
|
|||
| this.state = { | |||
| isCalloutVisible: false, | |||
| selectedLegend: props.legendProps?.selectedLegend ?? '', | |||
| activeLegend: '', | |||
| selectedLegends: [], | |||
AtishayMsft
reviewed
Dec 25, 2024
| this.state.selectedLegend === legendTitle || | ||
| (this.state.selectedLegend === '' && this.state.activeLegend === legendTitle) | ||
| ); | ||
| private _legendHighlighted = (legendTitle: string): boolean => { |
There was a problem hiding this comment.
_legendHighlighted was already there, so didn't change the name. Will change
AtishayMsft
reviewed
Dec 25, 2024
| this.setState({ | ||
| refSelected, | ||
| isCalloutVisible: true, | ||
| isCalloutVisible: stack.chartData.length > 0 || (stack.lineData?.length ?? 0) > 0, |
There was a problem hiding this comment.
yes, for stacks which does not have line data, checked it explicitly. For example, in the second data point, there is no line data.
[ { x: 80000, y: 20000, legend: 'Elephants', color: getColorFromToken(DataVizPalette.color11), xAxisCalloutData: '2020/04/30', yAxisCalloutData: '8%', lineData: { y: 16000, yAxisCalloutData: '7%', }, }, { x: 92000, y: 45000, legend: 'Monkeys', color: getColorFromToken(DataVizPalette.color6), xAxisCalloutData: '2020/04/30', yAxisCalloutData: '19%' ]
Without this check, it will show something like:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for multiple legend selection for Vertical Stacked Bar Chart