-
Notifications
You must be signed in to change notification settings - Fork 518
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrading Firely packages to v5. #4754
base: main
Are you sure you want to change the base?
Conversation
test/Microsoft.Health.Fhir.Shared.Tests.E2E/Rest/Search/BasicSearchTests.cs
Show resolved
Hide resolved
@tarunmathew12 please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
@@ -451,7 +455,11 @@ protected override async Task OnInitializedAsync() | |||
{ | |||
Meta = new Meta { Tag = new List<Coding> { new Coding("testTag", Tag) } }, | |||
Type = Group.GroupType.Person, | |||
#if !R5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What I don't like about the conditionals in this way is that its likely going to be this way from 5+, so this code will break on every new versions too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tldr is we have a known number of previous versions and an unknown number of future versions :)
Description
Upgrading Firely packages to v5.
Related issues
Addresses [issue #120833].
User Story 120833: Geneva Action - Review the action for Gen1 reprovision to avoid conflicts between AKS and SF
Testing
Tested by running E2E and integration tests locally.
FHIR Team Checklist
Semver Change (docs)
Patch|Skip|Feature|Breaking (reason)