Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Database schema optimizations #4731

Open
wants to merge 80 commits into
base: main
Choose a base branch
from

Conversation

SergeyGaluzo
Copy link
Contributor

@SergeyGaluzo SergeyGaluzo commented Nov 19, 2024

Optimizations:

  1. History/current resources split with removal of not needed indexes.
  2. Raw resources in separate table.
  3. Resource id integer mapping.
  4. Enabled writes/reads of raw resources to/from ADLS.
  5. Extended string reference id length.

Deployment is dependent on small schema change creating CurrentResource view. #4755

https://microsofthealth.visualstudio.com/Health/_workitems/edit/135369

SergeyGaluzo and others added 30 commits September 27, 2024 08:42
* History separation V0

* Forgotten resource

* replace current by view

* TRUNCATE

* HardDelete

* delete history v0

* missed 64 and removed dead code from SQL query generator

* Removed history from current in merge

* Triggers

* tests and tran

* disable/enable indexes

* rollback hard delete and merge

* rollback delete invisible history

* TRUNCATE -> DELETE

* line

* leftovers

* PK check

* Cosmetic

* WHERE nanes

* Get resources with forced indexes

* Removed redundant where

* Adding feature flag for raw resource dedupping

* Enable invisible history by default

* parameters

* commit

* fixed typo

* 65 + more realistic diff

* adjusted update trigger

* right trigger

* next iteration

* special chars

* Added delete and update

* \r

* Adding script runner

* Added verification

* cosmetic

* HOLDLOCK hint

* removed incorrect comments

* RT

* lock timeout

* 180 and remove empty

* no changes in update resource search params

* blob rewriter tool

* Revert "no changes in update resource search params"

This reverts commit b2e0c38.

* comment

* Generic disable indexes and update search params

* Dummy resources

* fixes

* Dummy records based on surr id

* adjust test to filter dummy rows

* exclude history and current

* Adding PerfTest V-1

* Get asyn wrapper without type string to id function

* tool

* not exists on data copy

* packages back

* Added comments.

* Correct filtered index on resource current

* Added redundant IsHistory=0 to index

* deduping

* Removed dummy records

* pp-p

* history clause

* deduping

* testing parameters

* get resource by type and surr id range with many versions

* skip large databases

* Added calls to fhir

* added conflict

* max retries = 3

* database pings

* examples

* reverse

* start closer

* put logic

* Create

* Move 65 to 84

* Fixes after merge

* Adding RawResources table

* change capture tweeks

* Test fix

* Added MI

* inline insert

* Repeat on updates
internal class SqlAdlsCient
{
private static readonly object _parameterLocker = new object();
private static string _adlsContainerName;

Check notice

Code scanning / CodeQL

Missed 'readonly' opportunity Note

Field '_adlsContainerName' can be 'readonly'.
{
private static readonly object _parameterLocker = new object();
private static string _adlsContainerName;
private static string _adlsConnectionString;

Check notice

Code scanning / CodeQL

Missed 'readonly' opportunity Note

Field '_adlsConnectionString' can be 'readonly'.
private static readonly object _parameterLocker = new object();
private static string _adlsContainerName;
private static string _adlsConnectionString;
private static string _adlsAccountName;

Check notice

Code scanning / CodeQL

Missed 'readonly' opportunity Note

Field '_adlsAccountName' can be 'readonly'.
private static string _adlsContainerName;
private static string _adlsConnectionString;
private static string _adlsAccountName;
private static string _adlsAccountKey;

Check notice

Code scanning / CodeQL

Missed 'readonly' opportunity Note

Field '_adlsAccountKey' can be 'readonly'.
private static string _adlsConnectionString;
private static string _adlsAccountName;
private static string _adlsAccountKey;
private static Uri _adlsAccountUri;

Check notice

Code scanning / CodeQL

Missed 'readonly' opportunity Note

Field '_adlsAccountUri' can be 'readonly'.
var uriStr = GetStorageParameter(sqlRetryService, logger, "MergeResources.AdlsAccountUri");
if (uriStr != null)
{
_adlsAccountUri = new Uri(uriStr);

Check notice

Code scanning / CodeQL

Static field written by instance method Note

Write to static field from instance method, property, or constructor.
if (uriStr != null)
{
_adlsAccountUri = new Uri(uriStr);
_adlsAccountManagedIdentityClientId = GetStorageParameter(sqlRetryService, logger, "MergeResources.AdlsAccountManagedIdentityClientId");

Check notice

Code scanning / CodeQL

Static field written by instance method Note

Write to static field from instance method, property, or constructor.
_adlsContainer = GetContainer();
}

_adlsIsSet = true;

Check notice

Code scanning / CodeQL

Static field written by instance method Note

Write to static field from instance method, property, or constructor.
Comment on lines +87 to +90
catch (Exception)
{
return null;
}

Check notice

Code scanning / CodeQL

Generic catch clause Note

Generic catch clause.
@SergeyGaluzo
Copy link
Contributor Author

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@microsoft microsoft deleted a comment from azure-pipelines bot Dec 24, 2024

if (_adlsConnectionString != null || _adlsAccountUri != null)
{
_adlsContainer = GetContainer();

Check notice

Code scanning / CodeQL

Static field written by instance method Note

Write to static field from instance method, property, or constructor.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Azure Healthcare APIs Label denotes that the issue or PR is relevant to the FHIR service in the Azure Healthcare APIs Enhancement Enhancement on existing functionality. Schema Version backward compatible
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant