-
Notifications
You must be signed in to change notification settings - Fork 518
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Database schema optimizations #4731
base: main
Are you sure you want to change the base?
Conversation
* History separation V0 * Forgotten resource * replace current by view * TRUNCATE * HardDelete * delete history v0 * missed 64 and removed dead code from SQL query generator * Removed history from current in merge * Triggers * tests and tran * disable/enable indexes * rollback hard delete and merge * rollback delete invisible history * TRUNCATE -> DELETE * line * leftovers * PK check * Cosmetic * WHERE nanes * Get resources with forced indexes * Removed redundant where * Adding feature flag for raw resource dedupping * Enable invisible history by default * parameters * commit * fixed typo * 65 + more realistic diff * adjusted update trigger * right trigger * next iteration * special chars * Added delete and update * \r * Adding script runner * Added verification * cosmetic * HOLDLOCK hint * removed incorrect comments * RT * lock timeout * 180 and remove empty * no changes in update resource search params * blob rewriter tool * Revert "no changes in update resource search params" This reverts commit b2e0c38. * comment * Generic disable indexes and update search params * Dummy resources * fixes * Dummy records based on surr id * adjust test to filter dummy rows * exclude history and current * Adding PerfTest V-1 * Get asyn wrapper without type string to id function * tool * not exists on data copy * packages back * Added comments. * Correct filtered index on resource current * Added redundant IsHistory=0 to index * deduping * Removed dummy records * pp-p * history clause * deduping * testing parameters * get resource by type and surr id range with many versions * skip large databases * Added calls to fhir * added conflict * max retries = 3 * database pings * examples * reverse * start closer * put logic * Create * Move 65 to 84 * Fixes after merge * Adding RawResources table * change capture tweeks * Test fix * Added MI * inline insert * Repeat on updates
… users/sergal/newschemarefsep
internal class SqlAdlsCient | ||
{ | ||
private static readonly object _parameterLocker = new object(); | ||
private static string _adlsContainerName; |
Check notice
Code scanning / CodeQL
Missed 'readonly' opportunity Note
{ | ||
private static readonly object _parameterLocker = new object(); | ||
private static string _adlsContainerName; | ||
private static string _adlsConnectionString; |
Check notice
Code scanning / CodeQL
Missed 'readonly' opportunity Note
private static readonly object _parameterLocker = new object(); | ||
private static string _adlsContainerName; | ||
private static string _adlsConnectionString; | ||
private static string _adlsAccountName; |
Check notice
Code scanning / CodeQL
Missed 'readonly' opportunity Note
private static string _adlsContainerName; | ||
private static string _adlsConnectionString; | ||
private static string _adlsAccountName; | ||
private static string _adlsAccountKey; |
Check notice
Code scanning / CodeQL
Missed 'readonly' opportunity Note
private static string _adlsConnectionString; | ||
private static string _adlsAccountName; | ||
private static string _adlsAccountKey; | ||
private static Uri _adlsAccountUri; |
Check notice
Code scanning / CodeQL
Missed 'readonly' opportunity Note
var uriStr = GetStorageParameter(sqlRetryService, logger, "MergeResources.AdlsAccountUri"); | ||
if (uriStr != null) | ||
{ | ||
_adlsAccountUri = new Uri(uriStr); |
Check notice
Code scanning / CodeQL
Static field written by instance method Note
if (uriStr != null) | ||
{ | ||
_adlsAccountUri = new Uri(uriStr); | ||
_adlsAccountManagedIdentityClientId = GetStorageParameter(sqlRetryService, logger, "MergeResources.AdlsAccountManagedIdentityClientId"); |
Check notice
Code scanning / CodeQL
Static field written by instance method Note
_adlsContainer = GetContainer(); | ||
} | ||
|
||
_adlsIsSet = true; |
Check notice
Code scanning / CodeQL
Static field written by instance method Note
catch (Exception) | ||
{ | ||
return null; | ||
} |
Check notice
Code scanning / CodeQL
Generic catch clause Note
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Optimizations:
Deployment is dependent on small schema change creating CurrentResource view. #4755
https://microsofthealth.visualstudio.com/Health/_workitems/edit/135369