Updating the error message during conditional reference #4691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nts to Multiple Records
v-shnarang
added
Azure API for FHIR
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
| @@ -70,10 +70,14 @@ public async Task ResolveReferencesAsync(Resource resource, IDictionary<string, | |||
|
|
|||
| var results = await GetExistingResourceId(requestUrl, resourceType, conditionalQueries, cancellationToken); | |||
|
|
|||
| if (results == null || results.Count != 1) | |||
| if (results == null) | |||
There was a problem hiding this comment.
Just to be safe, can you add results.Count == 0 to this if statement.
There was a problem hiding this comment.
@LTA-Thinking Updated the if statement. Please review it.
| { | ||
| throw new RequestNotValidException(string.Format(Core.Resources.InvalidConditionalReference, reference.Reference)); | ||
| } | ||
| else if (results.Count != 1) |
There was a problem hiding this comment.
And could you change this check to be if the count is greater than 1.
There was a problem hiding this comment.
For conditional, we want exactly 1, my only other thought here was 0 (if thats possible), which would still give the wrong error message
There was a problem hiding this comment.
@LTA-Thinking , @brendankowitz Updated the if else statement which cover both count = 0 and count >1 condition.
brendankowitz
previously approved these changes
Oct 22, 2024
LTA-Thinking
previously approved these changes
Oct 23, 2024
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Commenter does not have sufficient privileges for PR 4691 in repo microsoft/fhir-server |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
PTaladay
previously approved these changes
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The PR updates the error message of conditional references when multiple resources are found. Instead of stating "does not resolve to a resource," the message will now indicate that the reference resolved to multiple resources.
Related issues
Addresses issue #77964.
Testing
These changes were tested on the OSS FHIR server, and we received the expected error output.
FHIR Team Checklist
Semver Change (docs)
Patch|Skip|Feature|Breaking (reason)