Adding Authorization for Github api call In KubeLoginInstallerV0 #20725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deekshitha981
requested review from
YevheniiKholodkov,
manolerazvan and
a team
as code owners
|
/ azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
…ubAPICallInKubeLoginInstallerV0
2 tasks
…ubAPICallInKubeLoginInstallerV0
…ubAPICallInKubeLoginInstallerV0
z00sts
requested changes
Dec 17, 2024
Tasks/KubeloginInstallerV0/utils.ts
Outdated
| if (taskLib.getBoolFeatureFlag('USE_AUTHORIZATION_FOR_API_CALL')){ | ||
| const token = getGithubEndPointToken(); | ||
| if (token) { | ||
| request.headers['Authorization'] = 'token ' + token; |
There was a problem hiding this comment.
Let's extract explicit utility method to reduce code duplication
There was a problem hiding this comment.
Implemented the utlity code
Tasks/KubeloginInstallerV0/utils.ts
Outdated
| } else if (githubEndpointObject.scheme) { | ||
| throw new Error(taskLib.loc("InvalidEndpointAuthScheme", githubEndpointObject.scheme)); | ||
| } | ||
| } |
There was a problem hiding this comment.
Let's reduce code nesting by inverting if (!!githubEndpointObject) {
There was a problem hiding this comment.
Used switch block
Tasks/KubeloginInstallerV0/utils.ts
Outdated
| } | ||
| catch(error) | ||
| { | ||
| throw new Error(taskLib.loc("Failed to retrieve GitHub endpoint token:", error.message)); |
There was a problem hiding this comment.
Let's create less generic exception type here.
…ubAPICallInKubeLoginInstallerV0
…beLoginInstallerV0' of https://github.com/microsoft/azure-pipelines-tasks into users/v-dmerugu/AddingAuthorizationForGithubAPICallInKubeLoginInstallerV0
…ubAPICallInKubeLoginInstallerV0
…ubAPICallInKubeLoginInstallerV0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task name: KubeLoginInstallerV0
Description: KubeloginInstallerV0 task is calling github API anonymously, so here we are adding authorization using Oauth and pat to access the github API.
Documentation changes required: (Y/N) N
Added unit tests: (Y/N) N
Attached related issue: https://github.com/microsoft/azure-pipelines-tasks/issues/19097
Checklist: