Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added AzureRmWebAppDeploymentV5 to support OneDeploy for Linux App Service #20703

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

ShilpiRachna1
Copy link

@ShilpiRachna1 ShilpiRachna1 commented Nov 29, 2024

Task name: AzureRmWebAppDeployment

Description:

  1. Added AzureRmWebAppDeploymentV5 to support OneDeploy for Linux App Service.
  2. OneDeploy supports both clean (default) and incremental deployment options. For incremental deployment option, user needs to specify AdditionalArguments parameter with '-clean:false'
  3. We can fallback to ZipDeploy by specifying DeploymentType parameter as zipDeploy.
  4. Both onedeploy and zipDeploy for LinuxAppService use the newer version of common package (Added checksum header to kudu deployment request conditionally azure-pipelines-tasks-common-packages#411) to compute checksum for the attached zip or jar file.

PR #20736 shows changes in V5 w.r.t. V4.

Documentation changes required: (Y/N)

Added unit tests: (Y/N)

Attached related issue: (Y/N)

Checklist:

  • Task version was bumped - please check instruction how to do it
  • Checked that applied changes work as expected

Localization changes: #20737

@ShilpiRachna1
Copy link
Author

This PR depends on microsoft/azure-pipelines-tasks-common-packages#411 and should be merged only after that PR is merged.

@z00sts z00sts self-requested a review December 17, 2024 11:51
Copy link
Contributor

@z00sts z00sts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
Is it possible to split this PR into few?

Also, can you fix those lines in the description?
image

Copy link
Contributor

@v-schhabra v-schhabra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ShilpiRachna1
When we are selecting webapp of type Linux then actually in the UI of release pipeline we do not have "Additional argument" text box.
So, it would not be possible to give any arguments here or to select one deploy incremental deployment option.

"@types/q": "1.0.7",
"agent-base": "^6.0.2",
"azure-pipelines-task-lib": "4.11.0",
"azure-pipelines-tasks-azure-arm-rest": "^3.246.4",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ShilpiRachna1
Please update here the package version of "azure-pipelines-tasks-azure-arm-rest".

@ShilpiRachna1
Copy link
Author

Hi @ShilpiRachna1 When we are selecting webapp of type Linux then actually in the UI of release pipeline we do not have "Additional argument" text box. So, it would not be possible to give any arguments here or to select one deploy incremental deployment option.

Fixed the UI. Please test again

@ShilpiRachna1
Copy link
Author

ShilpiRachna1 commented Dec 22, 2024

image Is it possible to split this PR into few?

Also, can you fix those lines in the description? image

@z00sts - Since this is a new major version of the task, I am not sure if I can split the PR. If it helps, I have created another PR copying the newer changes to older version of the same task - that could help understand what is actually changing.

https://github.com/microsoft/azure-pipelines-tasks/pull/20736/files

Please let me know if there is anything else I can do to make the review process easier.

Will make other changes as suggested. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants