Add additional partition types. #54
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extend the partition `type` field so that it supports other values. e.g. `root`, `var`, etc. These new values map to well-known partition type UUIDs. In addition, allow the user to specify a UUID string in the `type` field in case we don't yet have a friendly name for that UUID. Also, add check to ensure the ESP is mounted at `/boot/efi`.
romoh
reviewed
Dec 20, 2024
amritakohli
reviewed
Dec 20, 2024
amritakohli
reviewed
Dec 20, 2024
amritakohli
reviewed
Dec 20, 2024
amritakohli
reviewed
Dec 20, 2024
romoh
reviewed
Dec 20, 2024
romoh
reviewed
Dec 20, 2024
romoh
approved these changes
Dec 20, 2024
amritakohli
reviewed
Dec 20, 2024
amritakohli
reviewed
Dec 21, 2024
|
|
||
| - `xbootldr`: The `/boot` partition. | ||
|
|
||
| - A UUID string. |
There was a problem hiding this comment.
nit: "A partition UUID string" -- just think it would make it more clear
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extend the partition
typefield so that it supports other values. e.g.root,var, etc. These new values map to well-known partition type UUIDs. In addition, allow the user to specify a UUID string in thetypefield in case we don't yet have a friendly name for that UUID.Also, add check to ensure the ESP is mounted at
/boot/efi.Checklist