imagehistory tests #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwize1
requested changes
Dec 20, 2024
amritakohli
force-pushed
the
user/amritakohli/imagehistorytest
branch
from
4443184 to
652620c
Compare
cwize1
previously approved these changes
Dec 20, 2024
cwize1
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added tests for image history.
Test cases:
Moved redactedString to a constant so it can be reused in the tests.
Added another file in additional dirs for good measure (I found that it helped while locally testing image history).
Added a config for image history that contains several different fields.
Possible future tests:
Test custom MarshalJSON functions that were added for image history
Test omitting JSON fields as selected
Checklist