-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add initial COSI support #40
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elainezhao96
commented
Dec 17, 2024
cwize1
requested changes
Dec 18, 2024
romoh
reviewed
Dec 18, 2024
…nto user/elaine/cosi
romoh
reviewed
Dec 18, 2024
…nto user/elaine/cosi
cwize1
requested changes
Dec 19, 2024
…nto user/elaine/cosi
cwize1
approved these changes
Dec 20, 2024
import ( | ||
"archive/tar" | ||
"crypto/sha512" | ||
_ "embed" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is embed
import needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oops it should be removed. I'll do it in follow up pr
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR summary:
This is a phase 1 COSI support, verity images support is not included. Enable COSI output, which involves steps like converting vhdx image to raw, extract partition images, generate metadata, and package everything into the final COSI tarball.
some local testing
with command
sudo ./imagecustomizer --log-level debug --build-dir ./build --image-file core-3.0.20241213.vhdx --output-image-file ./output-image-test.cosi --output-image-format cosi --config-file ../pkg/imagecustomizerlib/testdata/newpartitionsuuids-config.yaml
Checklist