Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initial COSI support #40

Merged
merged 8 commits into from
Dec 20, 2024
Merged

Add initial COSI support #40

merged 8 commits into from
Dec 20, 2024

Conversation

elainezhao96
Copy link
Contributor

@elainezhao96 elainezhao96 commented Dec 17, 2024

PR summary:

This is a phase 1 COSI support, verity images support is not included. Enable COSI output, which involves steps like converting vhdx image to raw, extract partition images, generate metadata, and package everything into the final COSI tarball.

some local testing
with command sudo ./imagecustomizer --log-level debug --build-dir ./build --image-file core-3.0.20241213.vhdx --output-image-file ./output-image-test.cosi --output-image-format cosi --config-file ../pkg/imagecustomizerlib/testdata/newpartitionsuuids-config.yaml

image


Checklist

  • Tests added/updated
  • Documentation updated (if needed)
  • Code conforms to style guidelines

toolkit/tools/pkg/imagecustomizerlib/imagecustomizer.go Outdated Show resolved Hide resolved
toolkit/tools/pkg/imagecustomizerlib/imagecustomizer.go Outdated Show resolved Hide resolved
toolkit/tools/pkg/imagecustomizerlib/imagecustomizer.go Outdated Show resolved Hide resolved
toolkit/tools/pkg/imagecustomizerlib/imagecustomizer.go Outdated Show resolved Hide resolved
toolkit/tools/pkg/imagecustomizerlib/imagecustomizer.go Outdated Show resolved Hide resolved
toolkit/tools/pkg/imagecustomizerlib/cosicommon.go Outdated Show resolved Hide resolved
toolkit/tools/pkg/imagecustomizerlib/cosicommon.go Outdated Show resolved Hide resolved
toolkit/tools/pkg/imagecustomizerlib/cosicommon.go Outdated Show resolved Hide resolved
toolkit/tools/pkg/imagecustomizerlib/cosicommon.go Outdated Show resolved Hide resolved
toolkit/tools/pkg/imagecustomizerlib/cosicommon.go Outdated Show resolved Hide resolved
docs/imagecustomizer/cli.md Outdated Show resolved Hide resolved
docs/imagecustomizer/cli.md Outdated Show resolved Hide resolved
@elainezhao96 elainezhao96 marked this pull request as ready for review December 19, 2024 06:44
@elainezhao96 elainezhao96 requested a review from a team as a code owner December 19, 2024 06:44
import (
"archive/tar"
"crypto/sha512"
_ "embed"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is embed import needed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops it should be removed. I'll do it in follow up pr

@elainezhao96 elainezhao96 merged commit 30fe585 into main Dec 20, 2024
7 checks passed
@elainezhao96 elainezhao96 deleted the user/elaine/cosi branch December 20, 2024 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants