OSModifier: Extend EMU API to update verity and root device #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwize1
requested changes
Dec 13, 2024
| // Must be 'root' for the rootfs (/) filesystem. | ||
| Name string `yaml:"name"` | ||
| // The ID of the 'Partition' to use as the data partition. | ||
| DataDeviceId string `yaml:"dataDeviceId"` |
There was a problem hiding this comment.
Rename to DataDevice and HashDevice.
(The Id suffix refers to the Id property on Partition type.)
| if err != nil { | ||
| return err | ||
| } | ||
| err = imagecustomizerlib.AddKernelCommandLine(osConfig.KernelCommandLine.ExtraCommandLine, dummyChroot) |
There was a problem hiding this comment.
You could call bootCustomizer.AddKernelCommandLine here.
…nto user/elaine/emu-grub
|
Might be worth checking whether the differences between MIC and Trident's verity handling are because Trident doesn't need all the same functionality, or if they're partly things that Trident just hasn't implemented yet. For instance, I know that /usr verity is something that we've talked about wanting for Trident, though that would be instead of root verity so there'd still only be one verity device. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a pr that moved from https://github.com/microsoft/azurelinux/pull/10584/files from old repo with comments addressed.
Changes included:
Checklist