Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the type of Intl.DurationFormat to the lib. #60646

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

developer-bandi
Copy link

@developer-bandi developer-bandi commented Dec 1, 2024

Add initial type for prototype

Fixes #60608

Add initial type for prototype
@typescript-bot typescript-bot added the For Backlog Bug PRs that fix a backlog bug label Dec 1, 2024
@developer-bandi developer-bandi marked this pull request as draft December 1, 2024 14:33
@developer-bandi
Copy link
Author

@microsoft-github-policy-service agree

@developer-bandi developer-bandi marked this pull request as ready for review December 8, 2024 08:07
@developer-bandi
Copy link
Author

@jakebailey
Copy link
Member

Your CI is passing linting, so I'm not sure what you mean.

The section you are looking for to fix tests is https://github.com/microsoft/TypeScript/blob/main/CONTRIBUTING.md#managing-the-baselines

For formatting, run npx dprint fmt and commit the result.

@@ -56,7 +56,7 @@ declare namespace Intl {
*
* [MDN](https://developer.mozilla.org/docs/Web/JavaScript/Reference/Global_Objects/Intl#Locale_negotiation).
*/
type RelativeTimeFormatLocaleMatcher = "lookup" | "best fit";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This type must not be renamed, as that would be a breaking change.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All existing type modifications were returned, and only cases where the existing type name was not applied were left. If there are any issues with this item, I will reinstate it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
For Backlog Bug PRs that fix a backlog bug
Projects
Status: Not started
Development

Successfully merging this pull request may close these issues.

Intl.DurationFormat missing from library definitions
3 participants