-
Notifications
You must be signed in to change notification settings - Fork 12.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the type of Intl.DurationFormat to the lib. #60646
base: main
Are you sure you want to change the base?
Add the type of Intl.DurationFormat to the lib. #60646
Conversation
@microsoft-github-policy-service agree |
I referred to the two links below, but lint does not work properly. Can I get help? -https://github.com/microsoft/TypeScript/blob/main/CONTRIBUTING.md#get-started |
Your CI is passing linting, so I'm not sure what you mean. The section you are looking for to fix tests is https://github.com/microsoft/TypeScript/blob/main/CONTRIBUTING.md#managing-the-baselines For formatting, run |
src/lib/es2020.intl.d.ts
Outdated
@@ -56,7 +56,7 @@ declare namespace Intl { | |||
* | |||
* [MDN](https://developer.mozilla.org/docs/Web/JavaScript/Reference/Global_Objects/Intl#Locale_negotiation). | |||
*/ | |||
type RelativeTimeFormatLocaleMatcher = "lookup" | "best fit"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This type must not be renamed, as that would be a breaking change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All existing type modifications were returned, and only cases where the existing type name was not applied were left. If there are any issues with this item, I will reinstate it.
Add initial type for prototype
Fixes #60608