Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev #2028

Merged
merged 14 commits into from
Dec 24, 2024
Merged

dev #2028

merged 14 commits into from
Dec 24, 2024

Conversation

baywet and others added 10 commits December 20, 2024 10:47
fix: reverts to a regular variable for the tag value
Bumps [Verify.Xunit](https://github.com/VerifyTests/Verify) from 28.6.1 to 28.7.0.
- [Release notes](https://github.com/VerifyTests/Verify/releases)
- [Commits](VerifyTests/Verify@28.6.1...28.7.0)

---
updated-dependencies:
- dependency-name: Verify.Xunit
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
…-28.7.0

chore(deps): bump Verify.Xunit from 28.6.1 to 28.7.0
@baywet baywet self-assigned this Dec 24, 2024
Comment on lines +102 to +105
if (value.GetValueKind() == JsonValueKind.Number)
Value = value.GetValue<decimal>().ToString(CultureInfo.InvariantCulture);
else
Value = value.GetValue<string>();

Check notice

Code scanning / CodeQL

Missed ternary opportunity Note

Both branches of this 'if' statement write to the same variable - consider using '?' to express intent better.
baywet and others added 3 commits December 24, 2024 09:18
@baywet baywet merged commit cce2495 into main Dec 24, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants