Merged PR 744563: Do not declare yarn.lock as a static input in yarn SDK

Some repos rewrite yarn.lock during the build and declaring it as a static input blocks the safe source rewrite feature.
microsoft · Oct 10, 2023 · ffe7434 · ffe7434
1 parent 165361b
commit ffe7434
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 2 deletions.
diff --git a/Public/Sdk/Public/JavaScript/yarn.dsc b/Public/Sdk/Public/JavaScript/yarn.dsc
@@ -160,7 +160,6 @@ namespace Yarn {
                 {kind: "shared", directory: d`${arguments.repoRoot}`},
             ],
             dependencies: [
-                f`${arguments.repoRoot}/yarn.lock`,
                 ...setCacheResult.getOutputFiles(), 
                 ...additionalDependencies],
             unsafe: unsafeArgs,

diff --git a/Public/Sdk/UnitTests/JavaScript/Test.JavaScript/runYarnInstall.lkg b/Public/Sdk/UnitTests/JavaScript/Test.JavaScript/runYarnInstall.lkg
@@ -74,7 +74,7 @@ Transformer.execute({
         ],
     },
     workingDirectory: d`./Out/src`,
-    dependencies: [f`./path/to/yarn`, f`./Out/src/yarn.lock`, f`./obj_test/k/w/6k5ykzrovlnle3hdbgx4lv7q/userprofile/.yarnrc`],
+    dependencies: [f`./path/to/yarn`, f`./obj_test/k/w/6k5ykzrovlnle3hdbgx4lv7q/userprofile/.yarnrc`],
     implicitOutputs: [d`./Out/src`],
     environmentVariables: [
         {name: "APPDATA", isPassThrough: true},