-
Notifications
You must be signed in to change notification settings - Fork 22.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Maintenance: CSS flex guide: updates to guide 5 #34237
Conversation
Preview URLs (comment last updated: 2024-07-03 16:05:13) |
This pull request has merge conflicts that must be resolved before it can be merged. |
...eb/css/css_flexible_box_layout/controlling_ratios_of_flex_items_along_the_main_axis/index.md
Outdated
Show resolved
Hide resolved
…_of_flex_items_along_the_main_axis/index.md Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for improving this content, @estelle. I've added my editorial review.
...eb/css/css_flexible_box_layout/controlling_ratios_of_flex_items_along_the_main_axis/index.md
Outdated
Show resolved
Hide resolved
...eb/css/css_flexible_box_layout/controlling_ratios_of_flex_items_along_the_main_axis/index.md
Outdated
Show resolved
Hide resolved
...eb/css/css_flexible_box_layout/controlling_ratios_of_flex_items_along_the_main_axis/index.md
Outdated
Show resolved
Hide resolved
...eb/css/css_flexible_box_layout/controlling_ratios_of_flex_items_along_the_main_axis/index.md
Outdated
Show resolved
Hide resolved
...eb/css/css_flexible_box_layout/controlling_ratios_of_flex_items_along_the_main_axis/index.md
Outdated
Show resolved
Hide resolved
...eb/css/css_flexible_box_layout/controlling_ratios_of_flex_items_along_the_main_axis/index.md
Outdated
Show resolved
Hide resolved
...eb/css/css_flexible_box_layout/controlling_ratios_of_flex_items_along_the_main_axis/index.md
Outdated
Show resolved
Hide resolved
...eb/css/css_flexible_box_layout/controlling_ratios_of_flex_items_along_the_main_axis/index.md
Outdated
Show resolved
Hide resolved
...eb/css/css_flexible_box_layout/controlling_ratios_of_flex_items_along_the_main_axis/index.md
Outdated
Show resolved
Hide resolved
...eb/css/css_flexible_box_layout/controlling_ratios_of_flex_items_along_the_main_axis/index.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Dipika Bhattacharya <[email protected]>
...eb/css/css_flexible_box_layout/controlling_ratios_of_flex_items_along_the_main_axis/index.md
Show resolved
Hide resolved
…_of_flex_items_along_the_main_axis/index.md Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Thanks for the review. I've incorporated all your feedback. I also updated all the live examples because the flex container overflowed the example space on smaller screens. mdn/css-examples#187 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, the updates look good. There's only a very few nits. I can commit those and merge this PR.
...eb/css/css_flexible_box_layout/controlling_ratios_of_flex_items_along_the_main_axis/index.md
Outdated
Show resolved
Hide resolved
...eb/css/css_flexible_box_layout/controlling_ratios_of_flex_items_along_the_main_axis/index.md
Outdated
Show resolved
Hide resolved
...eb/css/css_flexible_box_layout/controlling_ratios_of_flex_items_along_the_main_axis/index.md
Outdated
Show resolved
Hide resolved
...eb/css/css_flexible_box_layout/controlling_ratios_of_flex_items_along_the_main_axis/index.md
Outdated
Show resolved
Hide resolved
…_of_flex_items_along_the_main_axis/index.md
Flexbox is well-supported, and the content value is fully supported. This update freshens up the guide and removes a lot of words to tighten it up, then adds clarification text, so it's about the same size :(.
updating guide as part of CSS baseline / interop openwebdocs/project#189 - subcomponent openwebdocs/project#202