-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update nodejs data for URLSearchParams
#24998
base: main
Are you sure you want to change the base?
Conversation
{ | ||
"version_added": "7.0.0", | ||
"version_removed": "7.5.0", | ||
"partial_implementation": true, | ||
"notes": "Only available as an internal instance." | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it's not exposed to the user, let's remove this entry.
{ | |
"version_added": "7.0.0", | |
"version_removed": "7.5.0", | |
"partial_implementation": true, | |
"notes": "Only available as an internal instance." | |
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
though the interface is not exposed directly, it can be accessed via URL.prototype.searchParams
(i.e. new url.URL('https://github.com/mdn/browser-compat-data/pull/24998').searchParams.__proto__.constructor
is the equal call to URLSearchParams
)
and another reason is that there is a rule which force parent feature' version must not be greater or equal than child feature's version
see also #25001 (comment) and #25007 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be great if the note explains what the developer must do to access the instance instead, like Only accessible via `URL.searchParams`.
. Could you rewrite the note accordingly (same for the other PRs)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with Vinyl and made a similar suggestion in #25007 (comment).
Ultimately, this explicitness is useful for readers, because when you read "Only available as an internal instance.", the next question you ask yourself is: "How can I access this instance?"
Co-authored-by: Claas Augner <[email protected]>
This pull request has merge conflicts that must be resolved before it can be merged. |
Summary
the support for
URLSearchParams
class is:URL.prototype.searchParams
)url
module,URL.prototype.searchParams
no longer returns an empty listsort()
methodurl
implementTest results and supporting details
https://nodejs.org/docs/latest/api/globals.html#urlsearchparams
https://nodejs.org/docs/latest/api/url.html#class-urlsearchparams
nodejs/node#7448
https://nodejs.org/en/blog/release/v7.0.0/
https://nodejs.org/en/blog/release/v6.13.0/
nodejs/node#9484
https://nodejs.org/en/blog/release/v7.3.0/
https://nodejs.org/en/blog/release/v6.13.0/
nodejs/node#10399
nodejs/node#10801
nodejs/node#11057
nodejs/node#17365
https://nodejs.org/en/blog/release/v7.5.0/
https://nodejs.org/en/blog/release/v6.13.0/
nodejs/node#11098
https://nodejs.org/en/blog/release/v7.7.0/
https://nodejs.org/en/blog/release/v6.13.0/
nodejs/node#11060
https://nodejs.org/en/blog/release/v7.10.0/
nodejs/node#18281
https://nodejs.org/en/blog/release/v10.0.0/
nodejs/node#47885
https://nodejs.org/en/blog/release/v20.2.0/
https://nodejs.org/en/blog/release/v18.18.0/
Related issues
see also #24997
see also nodejs/node#55806