Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clearing the Global default welcome text will cause a NULL parameter CRASH #39501

Open
wants to merge 1 commit into
base: 2.4-develop
Choose a base branch
from
Open

clearing the Global default welcome text will cause a NULL parameter CRASH #39501

wants to merge 1 commit into from

Conversation

ergohack
Copy link
Contributor

@ergohack ergohack commented Dec 20, 2024 •
edited by m2-assistant bot
Loading

Description (*)

Clearing the Global default Welcome Text will cause a NULL parameter to be passed to Escaper.php.
Added a parameter sanity check to avoid the site crash.

[2024-12-20T17:21:42.186669+00:00] main.CRITICAL: TypeError: addslashes(): Argument #1 ($string) must be of type string, null given in /home/jetrails/encircle.markets/html/vendor/magento/framework/Escaper.php:440
Stack trace:
#0 /home/jetrails/encircle.markets/html/vendor/magento/framework/Escaper.php(440): addslashes(NULL)
#1 /home/jetrails/encircle.markets/html/vendor/magento/module-theme/Block/Html/Header.php(62): Magento\Framework\Escaper->escapeQuote(NULL, true)
#2 /home/jetrails/encircle.markets/html/vendor/magento/module-theme/view/frontend/templates/html/header.phtml(11): Magento\Theme\Block\Html\Header->getWelcome()

Related Pull Requests

none

Fixed Issues (if relevant)

none

Manual testing scenarios (*)

  1. add a website to the 'All Stores' configuration page ./admin/system_store/index/key/…
  2. remove the Global default Welcome Text from the first item in the Content | Design/Configuration list ./theme/design_config/index/key/…
    *1. remove the Welcome Text from the [Header] section of the Global default.
  3. restart the web server; reload the home page for the newly added website [BOOM].

I have a two website configuration and removed the global default in favor of the configuration for the specific websites, causing my site to crash. I think the issue is that the newly added website started with no value set for the Welcome Text.

Questions or comments

Contribution checklist (*)

  • [ √ ] Pull request has a meaningful description of its purpose
  • [ √ ] All commits are accompanied by meaningful commit messages
  • [ - ] All new or changed code is covered with unit/integration tests (if applicable)
  • [ - ] README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • [ - ] All automated tests passed successfully (all builds are green)

Resolved issues:

  1. resolves [Issue] clearing the Global default welcome text will cause a NULL parameter CRASH #39507: clearing the Global default welcome text will cause a NULL parameter CRASH

@m2-assistant M2 Assistant
Copy link

m2-assistant bot commented Dec 20, 2024

Hi @ergohack. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.
❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:
  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

@ergohack ergohack changed the title clearing the Global default website icon will cause a NULL parameter CRASH clearing the Global default welcome text will cause a NULL parameter CRASH Dec 20, 2024
@engcom-Hotel
Copy link
Contributor

@magento create issue

@m2-assistant m2-assistant bot mentioned this pull request Dec 24, 2024
Open
@engcom-Hotel engcom-Hotel added Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it labels Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: pending review Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Issue] clearing the Global default welcome text will cause a NULL parameter CRASH
2 participants
@ergohack @engcom-Hotel