[Issue] clearing the Global default welcome text will cause a NULL parameter CRASH

[m2-assistant]

This issue is automatically created based on existing pull request: #39501: clearing the Global default welcome text will cause a NULL parameter CRASH

---

Description (*)

Clearing the Global default Welcome Text will cause a NULL parameter to be passed to Escaper.php.
Added a parameter sanity check to avoid the site crash.

[2024-12-20T17:21:42.186669+00:00] main.CRITICAL: TypeError: addslashes(): Argument #1 ($string) must be of type string, null given in /home/jetrails/encircle.markets/html/vendor/magento/framework/Escaper.php:440
Stack trace:
#0 /home/jetrails/encircle.markets/html/vendor/magento/framework/Escaper.php(440): addslashes(NULL)
#1 /home/jetrails/encircle.markets/html/vendor/magento/module-theme/Block/Html/Header.php(62): Magento\Framework\Escaper->escapeQuote(NULL, true)
#2 /home/jetrails/encircle.markets/html/vendor/magento/module-theme/view/frontend/templates/html/header.phtml(11): Magento\Theme\Block\Html\Header->getWelcome()

Related Pull Requests

none

Fixed Issues (if relevant)

none

Manual testing scenarios (*)

1. add a website to the 'All Stores' configuration page ./admin/system_store/index/key/…
2. remove the Global default Welcome Text from the first item in the Content | Design/Configuration list ./theme/design_config/index/key/…
   *1. remove the Welcome Text from the [Header] section of the Global default.
3. restart the web server; reload the home page for the newly added website [BOOM].

I have a two website configuration and removed the global default in favor of the configuration for the specific websites, causing my site to crash. I think the issue is that the newly added website started with no value set for the Welcome Text.

Questions or comments

Contribution checklist (*)

• [ √ ] Pull request has a meaningful description of its purpose
• [ √ ] All commits are accompanied by meaningful commit messages
• [ - ] All new or changed code is covered with unit/integration tests (if applicable)
• [ - ] README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
• [ - ] All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @engcom-Bravo. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

• 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
• 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
• 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
• 4. Verify that the issue is reproducible on 2.4-develop branch
  Details

  - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
• 5. Add label Issue: Confirmed once verification is complete.
• 6. Make sure that automatic system confirms that report has been added to the backlog.