Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: improve packages table #2674

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

docs: improve packages table #2674

wants to merge 4 commits into from

Conversation

realguse
Copy link
Contributor

@realguse realguse commented Dec 7, 2024 •
edited
Loading

What is the purpose of this pull request?

  • Documentation update

Description

Tries to make the packages table in the main README.md more clean and modern.

Before Submitting

@realguse realguse changed the title Improve readme docs: slightly overhaul readme Dec 7, 2024
@github-actions github-actions bot added ⚛️ react package Lucide React Package 💎 vue package Lucide Vue package ⚛️ preact package About the Preact Package 🧳 lucide package About the lucide package 🧣 svelte package About the Svelte package ⚛️ react native package About the React Native package 🪝 solid package About the Solid package 🅰️ angular package About the Angular package 🪨 static package About the static package labels Dec 7, 2024
@realguse realguse marked this pull request as ready for review December 7, 2024 20:00
@realguse realguse marked this pull request as draft December 16, 2024 16:26
@realguse realguse changed the title docs: slightly overhaul readme docs: overhaul readme table Dec 19, 2024
@realguse realguse changed the title docs: overhaul readme table docs: overhaul README table Dec 19, 2024
@realguse realguse closed this Dec 19, 2024
@realguse realguse reopened this Dec 19, 2024
@realguse realguse marked this pull request as ready for review December 19, 2024 20:00
@realguse realguse changed the title docs: overhaul README table docs: improve packages table Dec 19, 2024
ericfennis
ericfennis reviewed Dec 20, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
@realguse
Copy link
Contributor Author

Since i updated the badges to be in the flat-square style, should i also update the badges at the top of the readme to maintain the same style (will then be for-the-badge, which is just slightly bigger than flat-square

@jguddas
Copy link
Member

jguddas commented Dec 21, 2024

Can we also change the contrast, having light text on a light background is not very readable?
image

@realguse
Copy link
Contributor Author

realguse commented Dec 21, 2024 •
edited
Loading

Hi @jguddas, could you expand a bit more on the contrast "problem" (and maybe a possible solution), to make this simpler I'm gonna move the badge-changes to a new pr so i can also update all the other badges simultaneously.

@jguddas
Copy link
Member

jguddas commented Dec 21, 2024

Hi @jguddas, could you expand a bit more on the contrast "problem" (and maybe a possible solution), to make this simpler I'm gonna move the badge-changes to a new pr so i can also update all the other badges simultaneously.

I think we should change the foreground color from white to black.

@realguse realguse mentioned this pull request Dec 21, 2024
Closed
3 tasks
@realguse
Copy link
Contributor Author

Makes sense, will do that in #2704

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericfennis ericfennis ericfennis left review comments

Assignees
No one assigned
Labels
🅰️ angular package About the Angular package 🧳 lucide package About the lucide package ⚛️ preact package About the Preact Package ⚛️ react native package About the React Native package ⚛️ react package Lucide React Package 🪝 solid package About the Solid package 🪨 static package About the static package 🧣 svelte package About the Svelte package 💎 vue package Lucide Vue package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@realguse @jguddas @ericfennis