Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(icons): added asterisk-off icon #2660

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jamiemlaw
Copy link
Contributor

Closes #2606

What is the purpose of this pull request?

  • New Icon

Description

Added new asterisk-off icon.

Icon use case

To indicate that an item is optional, or to set an item as optional

Alternative icon designs

Icon Design Checklist

Concept

  • I have provided valid use cases for each icon.
  • I have not added any a brand or logo icon.
  • I have not used any hate symbols.
  • I have not included any religious or political imagery.

Author, credits & license

  • The icons are solely my own creation.
  • The icons were originally created in # by
  • I've based them on the following Lucide icons: asterisk
  • I've based them on the following design:

Naming

  • I've read and followed the naming conventions
  • I've named icons by what they are rather than their use case.
  • I've provided meta JSON files in icons/[iconName].json.

Design

  • I've read and followed the icon design guidelines
  • I've made sure that the icons look sharp on low DPI displays.
  • I've made sure that the icons look consistent with the icon set in size, optical volume and density.
  • I've made sure that the icons are visually centered.
  • I've correctly optimized all icons to three points of precision.

Before Submitting

@github-actions github-actions bot added 🎨 icon About new icons 🫧 metadata Improved metadata labels Dec 3, 2024
Copy link

github-actions bot commented Dec 3, 2024

Added or changed icons

icons/asterisk-off.svg

Preview cohesion icons/square-library.svg
icons/asterisk-off.svg
icons/refresh-cw-off.svg
Preview stroke widths icons/asterisk-off.svg
icons/asterisk-off.svg
icons/asterisk-off.svg
DPI Preview (24px) icons/asterisk-off.svg
Icon X-rays icons/asterisk-off.svg
Icon Diffs icons/asterisk-off.svg
Icons as code

Works for: lucide-react, lucide-react-native, lucide-preact, lucide-vue-next

const AsteriskOffIcon = createLucideIcon('AsteriskOff', [
  ["path",{"d":"M12 6.35V6"}],
  ["path",{"d":"M15.582 9.932 17.196 9"}],
  ["path",{"d":"m2 2 20 20"}],
  ["path",{"d":"M6.804 15 12 12v6"}],
  ["path",{"d":"M6.804 9 12 12"}]
])

@ericfennis
Copy link
Member

Not sure about this one, is it not better to use color/opacity to indicate if something is optional or not?

@karsa-mistmere
Copy link
Member

karsa-mistmere commented Dec 5, 2024

Not sure about this one, is it not better to use color/opacity to indicate if something is optional or not?

Not really, see WCAG 2.1 1.4.1, but I'm not sure about the use case for this icon either. Indicate that an item is optional where?

  • On the item itself?
    Just explicitly state (optional) or (required) (depending on which are in minority in the form in question)
  • On a UI where the "required-ness" of items is set?
    Just use a checkbox or toggle switch that explicitly states ☑︎ Required

@jamiemlaw
Copy link
Contributor Author

From the issue this closes, I imagined it was part of a form builder UI where you were setting whether a field is optional or not via a toggle:

image

But I'm 100% with @karsa-mistmere. More than happy to close if the use case isn't solid enough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎨 icon About new icons 🫧 metadata Improved metadata
Projects
None yet
Development

Successfully merging this pull request may close these issues.

asterisk-off icon
3 participants