Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document requirements for torch_mlir_e2e_test #3722

Merged
merged 2 commits into from
Sep 23, 2024

Conversation

marbre
Copy link
Member

@marbre marbre commented Sep 23, 2024

This documents which CMake options must be set to be able to use torch_mlir_e2e_test, required e.g. for
projects/pt1/tools/e2e_test.sh.

Makes progress on #3696.
Closes #3719.

This documents which CMake options must be set to be able to use
`torch_mlir_e2e_test`, required e.g. for
`projects/pt1/tools/e2e_test.sh`.

Makes progress on llvm#3696.
Closes llvm#3719.
@marbre marbre requested a review from zjgarvey September 23, 2024 09:24
Copy link
Collaborator

@zjgarvey zjgarvey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Marius.

Can you please add a section around line 111 in this file like:

### Flags required to run e2e tests locally:

Running the e2e tests requires enabling the JIT IR importer and pytorch extensions for your local build:
```shell
 -TORCH_MLIR_ENABLE_PYTORCH_EXTENSIONS=ON `
 -TORCH_MLIR_ENABLE_JIT_IR_IMPORTER=ON `

@marbre marbre requested a review from zjgarvey September 23, 2024 21:44
@marbre marbre force-pushed the docs.torch_mlir_e2e_test branch from ab95c72 to a1d967c Compare September 23, 2024 21:48
Copy link
Collaborator

@zjgarvey zjgarvey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@marbre marbre merged commit e4f2bdf into llvm:main Sep 23, 2024
3 checks passed
@marbre marbre deleted the docs.torch_mlir_e2e_test branch September 23, 2024 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

torch_mlir_e2e_test module not found when follow build instructions
2 participants