UUID Logical Type Support #257
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
use uuid.Parse() to ensure that a string received in a field with logicalType 'uuid' is truly a valid uuid
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've encountered a case where it would have been helpful to validate that a string in a field,
{"type": ["null", {"type": "string", "logicalType": "uuid"}], "default": null}, was in fact a uuid.To accomplish this, I've added two functions:
nativeFromUUIDanduuidFromNative. Both of these functions use uuid.Parse to validate that an outgoing or incoming string is a UUID. I went this route rather than using a regex because I found a gist that showed that google's uuid.Parse was much faster. Hopefully, the project is not too opposed to introducing a new package, but I am happy to hear objections.Please let me know if there's any changes I should make; I hope this is a useful contribution!