Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Drawer section #6034

Closed
wants to merge 11 commits into from
Closed

Conversation

NishantSinghhhhh
Copy link
Contributor

Description

This PR adds comprehensive documentation for the Drawer component, detailing its purpose, usage, and various configurations. The documentation covers key aspects like types of drawers (Temporary, Permanent, Modal, and Mini-Variant), functionality, styling guidelines, and common use cases, providing developers with clear insights on how to implement and customize Drawer components effectively in the application.

Changes Include:

Explanation of Drawer types and scenarios for each.
Guidelines on content structure within drawers to ensure usability.
Example implementations for Temporary, Permanent, Modal, and Mini-Variant drawers.
Best practices for accessibility and consistency with other UI elements.
Notes for Reviewers Please review the usage examples and descriptions provided for clarity and accuracy. Suggestions for any additional use cases or adjustments in styling recommendations are welcome.

Signed commits

Yes, I signed my commits.

Signed-off-by: NishantSinghhhhh <[email protected]>
@l5io
Copy link
Contributor

l5io commented Oct 27, 2024

🚀 Preview for commit aa6263d at: https://671e05d9fae585e97a1de7a6--layer5.netlify.app

@l5io
Copy link
Contributor

l5io commented Oct 27, 2024

🚀 Preview for commit 1e2a4fb at: https://671e13b9decd372fe435b7c4--layer5.netlify.app

Signed-off-by: NishantSinghhhhh <[email protected]>
@l5io
Copy link
Contributor

l5io commented Oct 27, 2024

🚀 Preview for commit c960d45 at: https://671e222c7288793ae1d0b1e4--layer5.netlify.app

@NishantSinghhhhh
Copy link
Contributor Author

@nebula-aac , @SAHU-01

Signed-off-by: NISHANT SINGH <[email protected]>
@l5io
Copy link
Contributor

l5io commented Oct 27, 2024

🚀 Preview for commit 09fbb95 at: https://671e41ed92866d27759a0578--layer5.netlify.app

@nebula-aac nebula-aac self-requested a review October 27, 2024 17:29
@vishalvivekm
Copy link
Contributor

@NishantSinghhhhh
Thank you for your contribution!
Let's discuss this during the website call on Monday at 5:30 PM IST (7:00 AM CT).

Please add it as an agenda item to the meeting minutes.

@NishantSinghhhhh
Copy link
Contributor Author

@sudhanshutech @vishalvivekm z can you review the PR

@l5io
Copy link
Contributor

l5io commented Oct 30, 2024

🚀 Preview for commit cce9d9d at: https://6722257b3b8ac4955f7afd1f--layer5.netlify.app

@leecalcote
Copy link
Member

Merge conflict

@NishantSinghhhhh
Copy link
Contributor Author

Merge conflict

Okay sir I will remove the merge conflicts

And I will will ping you in channel when I am done with this issue

@l5io
Copy link
Contributor

l5io commented Nov 9, 2024

🚀 Preview for commit c78ed7b at: https://672f2313fd824ef52bf2a082--layer5.netlify.app

Signed-off-by: NishantSinghhhhh <[email protected]>
@NishantSinghhhhh
Copy link
Contributor Author

@sudhanshutech, @vishalvivekm, @SAHU-01

Sir/Ma'am, I've implemented the requested changes. However, further reduction of the code visible to fellow developers may compromise its readability and structure. I've optimized it as much as possible without impacting clarity.

Let me know if there's anything more specific you'd like me to adjust.

@l5io
Copy link
Contributor

l5io commented Nov 9, 2024

🚀 Preview for commit 1063b9d at: https://672f379e45d9fc18914651ce--layer5.netlify.app

Signed-off-by: NishantSinghhhhh <[email protected]>
@l5io
Copy link
Contributor

l5io commented Nov 9, 2024

🚀 Preview for commit 0d6b997 at: https://672f3fd3e3f33713fde4a32a--layer5.netlify.app

@l5io
Copy link
Contributor

l5io commented Nov 18, 2024

🚀 Preview for commit 9d2d35f at: https://673b3ca0cbd35e1853a778a5--layer5.netlify.app

@Vidit-Kushwaha
Copy link
Contributor

Hi @NishantSinghhhhh Facing issues merging your PR in Sistent?

We are conducting a special tutorial on this Monday, December 16, 2024, at 7 AM Central (6:30 PM IST) in the website meeting. 

Get more information: here

👥 Get involved:

Don’t miss out. 🚀

@sudhanshutech
Copy link
Member

@NishantSinghhhhh please reopen them when you are back to complete them. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/projects An issue relating to Layer5 initiatives (projects) project/sistent
Development

Successfully merging this pull request may close these issues.

7 participants