Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[zh-cn] Resync storage-version-migration.md #49127

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[zh-cn] Resync storage-version-migration.md #49127

wants to merge 1 commit into from

Conversation

mengjiao-liu
Copy link
Member

@mengjiao-liu mengjiao-liu commented Dec 17, 2024 •
edited
Loading

Description

Issue

See the preview page

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from mengjiao-liu. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/localization General issues or PRs related to localization labels Dec 17, 2024
@k8s-ci-robot k8s-ci-robot added language/zh Issues or PRs related to Chinese language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 17, 2024
@netlify Netlify
Copy link

netlify bot commented Dec 17, 2024

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 99cb9e6
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/6760e5f055a36f0008f83e19
😎 Deploy Preview https://deploy-preview-49127--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

tengqm
tengqm reviewed Dec 18, 2024
View reviewed changes
content/zh-cn/docs/tasks/manage-kubernetes-objects/storage-version-migration.md
- aescbc:
keys:
- name: key1
secret: c2VjcmV0IGlzIHNlY3VyZQ==
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't like this revision, although I know this indentation is valid.
I always struggle with the nesting levels of list items when we have less indentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tengqm tengqm tengqm left review comments

@kinzhi kinzhi Awaiting requested review from kinzhi

@windsonsea windsonsea Awaiting requested review from windsonsea

Assignees
No one assigned
Labels
area/localization General issues or PRs related to localization cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/zh Issues or PRs related to Chinese language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mengjiao-liu @k8s-ci-robot @tengqm