Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test migration from ginkgo regexes to ginkgo labels #33440

Merged
merged 2 commits into from
Sep 8, 2024
Merged

test migration from ginkgo regexes to ginkgo labels #33440

merged 2 commits into from
Sep 8, 2024

Conversation

aojea
Copy link
Member

@aojea aojea commented Sep 8, 2024

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 8, 2024
@aojea aojea mentioned this pull request Sep 8, 2024
Merged
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aojea

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested a review from bowei September 8, 2024 16:19
@k8s-ci-robot k8s-ci-robot added the area/config Issues or PRs related to code in /config label Sep 8, 2024
@k8s-ci-robot k8s-ci-robot requested a review from cadmuxe September 8, 2024 16:19
@k8s-ci-robot k8s-ci-robot added area/jobs approved Indicates a PR has been approved by an approver from all required OWNERS files. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Sep 8, 2024
@adrianmoisey
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 8, 2024
@k8s-ci-robot k8s-ci-robot merged commit ba30036 into kubernetes:master Sep 8, 2024
7 checks passed
@k8s-ci-robot
Copy link
Contributor

@aojea: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key sig-network-kind.yaml using file config/jobs/kubernetes/sig-network/sig-network-kind.yaml

In response to this:

Ref: #32911 (comment)

/assign @adrianmoisey

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

aojea
aojea commented Sep 9, 2024
View reviewed changes
config/jobs/kubernetes/sig-network/sig-network-kind.yaml
- name: SKIP
value: \[Feature:(Networking-IPv6|Example|Federation|PerformanceDNS|ServiceCIDRs)\]|LB.health.check|LoadBalancer|load.balancer|GCE|NetworkPolicy|DualStack
- name: LABEL_FILTER
value: "(Conformance || sig-network ) && !Feature: containsAny {Alpha, Beta, Networking-IPv6, Example, Federation, PerformanceDNS, LoadBalancer} && !Disruptive && !Flaky"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

based on this https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/127167/pull-kubernetes-e2e-kind-nftables/1832871323144032256
@adrianmoisey can you send a PR that adds IPv6DualStack here, to the list of Features?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bowei bowei Awaiting requested review from bowei

@cadmuxe cadmuxe Awaiting requested review from cadmuxe

Assignees

@adrianmoisey adrianmoisey

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aojea @k8s-ci-robot @adrianmoisey