Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Profile Recorder: Add bpf_d_path implementation and hook mkdir, mknod, unlink. #2611

Draft
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

mhils
Copy link
Contributor

@mhils mhils commented Dec 10, 2024

What type of PR is this?

/kind feature

What this PR does / why we need it:

This PR adds a custom bpf_d_path implementation that can be used in eBPF hooks that are not allowlisted to actually use bpf_d_path. We then use this to hook mkdir, mknod, and unlink to create more comprehensive AppArmor profiles.

Which issue(s) this PR fixes:

None

Does this PR have test?

Yes

Special notes for your reviewer:

supersedes #2608

Does this PR introduce a user-facing change?

Profile recorder: Hook `mkdir`, `mknod`, and `unlink` for better AppArmor profiles

mhils added 8 commits December 9, 2024 13:58
this otherwise generates a wall of text that hides compiler errors
for example, `ARGS='-run "TestSpoc/record/AppArmor/directories"'` can be used to only run a particular test
this works around bpf limitations where bpf_d_path is unavailable in some hooks and also does not take stack-allocated path objects

additionally, add mknod and unlink hooks
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. labels Dec 10, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mhils
Once this PR has been reviewed and has the lgtm label, please assign saschagrunert for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 10, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @mhils. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Dec 10, 2024
@mhils mhils changed the title Mknod Profile Recorder: Add bpf_d_path implementation and hook mkdir, mknod, unlink. Dec 10, 2024
@codecov-commenter
Copy link

codecov-commenter commented Dec 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.38%. Comparing base (11d77f4) to head (c7e1b5b).
Report is 539 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2611      +/-   ##
==========================================
- Coverage   45.50%   41.38%   -4.12%     
==========================================
  Files          79      109      +30     
  Lines        7782    18239   +10457     
==========================================
+ Hits         3541     7549    +4008     
- Misses       4099    10191    +6092     
- Partials      142      499     +357     

@ccojocar
Copy link
Contributor

It seems that the entire overlay filesystem is added to the profile https://github.com/kubernetes-sigs/security-profiles-operator/actions/runs/12261338471/job/34208338061?pr=2611#step:8:170.

We need to filter out all these file permissions since is not required in the apaprmor profile.

@ccojocar
Copy link
Contributor

ccojocar commented Dec 11, 2024

I think we need to filter out the bootstraping and init phases of the container.

As far as I know the nsenter (https://github.com/opencontainers/runc/tree/main/libcontainer/nsenter) gets executed before runc init(https://github.com/opencontainers/runc/blob/4cb480de703f78876b92f7c6ca058a99956d27d9/init.go#L11) which executes itself and then starts the container init process. I believe that we should not record the resources before container init process.

I am think maybe is possible to filter out all resource associated with runc command. There is already this filter for syscalls

.

@mhils mhils marked this pull request as draft December 16, 2024 22:41
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 16, 2024
@k8s-ci-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/feature Categorizes issue or PR as related to a new feature. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants