Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: improve rendering of documentation #258

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

aepfli
Copy link
Member

@aepfli aepfli commented Mar 27, 2023

With this pull request, we're further improving the rendering of the community files.

The layout of all files has been improved, and links are working for all files. And a Netlify build is ready to be used so we can display the page and check the community files and how they will be rendered, eg. within the KLT.

see: https://deploy-preview-3--keptn-community.netlify.app/ rendered from the same branch within my fork

@aepfli aepfli changed the title Chore/improve docs part2 chore: improve rendering of documentation Mar 27, 2023
@aepfli aepfli marked this pull request as ready for review March 27, 2023 07:58
aepfli added 2 commits March 27, 2023 09:58
Adding additionally tools to verify build

Signed-off-by: Simon Schrottner <[email protected]>
Signed-off-by: Simon Schrottner <[email protected]>
# On netlify our branch will always be the one we are currently building for
# important information regarding naming
# https://gohugo.io/getting-started/configuration/#configure-with-environment-variables
HUGOxPARAMSxGITHUB_BRANCH="$BRANCH"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aepfli in KLT this seemed not to work, we had to explicitly pass it as an env var to the hug command, here

@RealAnna
Copy link
Contributor

RealAnna commented Aug 4, 2023

Hey @aepfli would this solve keptn/lifecycle-toolkit#1808 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

3 participants