Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add a fail-test for escaped non Unicode Scalar Values #452

Merged
merged 2 commits into from
Dec 24, 2024

Conversation

eugenesvk
Copy link
Contributor

Closes #451

Copy link
Member

@zkat zkat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably have separate failing cases for each thing we intend to test, otherwise a single (correct) failure might obscure failures for other items

@eugenesvk
Copy link
Contributor Author

Thought about that, but that's solved via parameterized tests, then can properly test that each \u codepoint in the range fails, otherwise didn't want to create hundreds of separate files, and without that it's no help separating 5 codepoints currently in the text out

@zkat
Copy link
Member

zkat commented Dec 24, 2024

I would prefer not to complicate the test suite right now. 4-6 tests at the appropriate boundaries should be “good enough”

@zkat zkat merged commit 3c1cf4f into kdl-org:main Dec 24, 2024
1 check passed
@eugenesvk eugenesvk deleted the pr-test branch December 24, 2024 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a test for escaped surrogates
2 participants