start.sh: JUPYTER_ENV_VARS_TO_UNSET introduced #1524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow you to define variables to be unset before running the command that start.sh is supposed to start. These variables will still be available in the hooks run before.
mathbunnyru
reviewed
Nov 12, 2021
|
Feel free to commit to my branch, since I won't be able to work on this for a while. I mainly wanted to cherry-pick the remaining commits into separate PRs before I forgot how everything went. |
mathbunnyru
requested changes
Nov 12, 2021
|
I added non-root case, let's hope it's gonna work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of b44b7ab. I'm working through #1512 (comment)