-
-
Notifications
You must be signed in to change notification settings - Fork 611
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: Reduce pip behaviour dependencies in test suite #2105
Open
ncoghlan
wants to merge
10
commits into
jazzband:main
Choose a base branch
from
ncoghlan:issue-2104-avoid-pip-freeze-protection-assumptions
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
ec585c5
CI: Avoid a pip behaviour dependency in test_sync
ncoghlan bc3f17b
Try to get build dependency compilation test passing
ncoghlan 2fd6cc6
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] bc26fbf
Revert "[pre-commit.ci] auto fixes from pre-commit.com hooks"
ncoghlan 14aef0f
Revert "Try to get build dependency compilation test passing"
ncoghlan c2bd925
Use known version of setuptools in test case
ncoghlan 00c339c
Try to get build dependency compilation test passing
ncoghlan 7e64706
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 3b8640a
Ignore Python __pycache__ folders
ncoghlan 5a46dd5
Merge branch 'main' into issue-2104-avoid-pip-freeze-protection-assum…
ncoghlan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,6 +2,7 @@ | |
*.t.err | ||
|
||
# Python cruft | ||
__pycache__ | ||
*.pyc | ||
|
||
# Virtualenvs | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What if this was to be made conditional? Perhaps, the test could be parametrized with variants before and after certain pip version that would run in different jobs (through the
skipif
mark). It'd be able to cover the concern of breaking on older versions…