-
-
Notifications
You must be signed in to change notification settings - Fork 429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrading to the latest redis-py release #607
base: master
Are you sure you want to change the base?
Conversation
@WisdomPill I ran (many) of these tests against many python versions locally, and they passed. Can we see if they run through your CI? If not - maybe I can help. Equally - I'd love to turn back to this issue regarding tox + dockers, and lend a hand! |
Codecov Report
@@ Coverage Diff @@
## master #607 +/- ##
======================================
Coverage 57.5% 57.5%
======================================
Files 39 39
Lines 2528 2528
Branches 75 74 -1
======================================
Hits 1452 1452
Misses 1059 1059
Partials 17 17
Flags with carried forward coverage won't be shown. Click here to find out more. 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Thanks @chayim for the contribution. Do you know if redis-py 3.x.x was supporting an older python version? It is just mypy is crashing, I will have a shot at it locally in the following days. About tox and docker, I would love to go back and finish that PR! |
@WisdomPill redis-py 3.x.x stopped being tested after redis ~6 I think. We're a few versions past that. If you'd like, I can help you use the release-drafter, as we are in Redis. It's similar to towncrier, except that it flat out takes the name of the PR, and uses labels. You know me... lazy ;) But the mypy issue could be the result of our finally embracing type hints in redis-py. It could both be out of date, and possibly crashing due to duplicates? |
Hi @chayim @WisdomPill, I was going to raise an issue here to bump Redis in light of the recent vulnerability redis/redis-py#2665 but found this pre-existing PR. Any chance of getting this PR bumped to >=4.5.4 and merged? |
oh, sure! thanks @elichad |
@WisdomPill I merged in, resolved, and updated redis-py but I don't grok the pre-commit.ci issue. Can you lend I hand? I did manually build a package locally (build/sdist) just to see if I had inadvertently broken something,. |
I saw that error in my day to day job, a simple upgrade of dependencies in pre-commit fixes the issues @chayim could you merge again master into your branch? |
Is this PR still relevant, considering the latest version in |
django-redis currently relies on not the latest version of redis. This is a small PR to bump the version.