Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect numbers when sorting #779

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Conversation

nwoltman
Copy link

@nwoltman nwoltman commented Oct 4, 2024

Fix #562 by checking if the values being sorted are both numbers and sorting them as numbers if they are.

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.60%. Comparing base (d32c85d) to head (5857111).
Report is 4 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #779      +/-   ##
==========================================
+ Coverage   93.54%   93.60%   +0.05%     
==========================================
  Files          19       19              
  Lines         837      844       +7     
  Branches      199      201       +2     
==========================================
+ Hits          783      790       +7     
  Misses         38       38              
  Partials       16       16              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not sorting negative numbers correctly. Reproduced on listjs.com
2 participants