Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add link to examples and revealjs.com to index.html slide #3395

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

timabell
Copy link

Took me a little while to find the examples, so this makes them a bit more discoverable.

Thanks for software, very useful.

Before

shutter_20234-13_04

After

shutter_20234-13_03

Took me a little while to find the examples, so this makes them a bit
more discoverable.
Github pages doesn't do directory listings by default

This is a bit hacky and manual but it works.
@timabell timabell force-pushed the expand-default-index branch from 94c1c90 to f2b6bf1 Compare April 13, 2023 10:52
@t-fritsch
Copy link
Collaborator

thanks for the PR @timabell ! 🙏

Making examples more visible is a good idea, maybe adding this to the README would be better (in the list of links in getting started section) ?

I guess @hakimel leaves default slides empty (apart "Slide 1" and "Slide 2" titles) to keep the default deck really simple, but maybe having this in the first slide is fine tho ?

Regarding the examples/index.html and examples/build-index.sh I wonder if it is really needed since we already have a file listing in the defaut webserver (launched with npm start) :
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants