Update faust2caqt for QT6 #711
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this change faust2caqt fails due to the usage of std::filesystem in QT6, with errors such as:
```/opt/homebrew/lib/QtCore.framework/Headers/qfileinfo.h:120:14: error: '~path' is unavailable: introduced in macOS 10.15
{ return QtPrivate::toFilesystemPath(absoluteFilePath()); }```
if supporting macOS < 10.15 is important, then this might not be the best fix
|
Actually, this is not enough. QT6 has a dependency on librotli it seems and it's not in /usr/local/lib where the .app expects it. It's possible to fix with but that means the .app is not portable |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this change faust2caqt fails due to the usage of std::filesystem in QT6, with errors such as:
if supporting macOS < 10.15 is important, then this might not be the best fix