rust: FaustDsp trait improvements #1099
Open
+83
−43
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has braking changes to the faust interface via the FaustDsp trait.
I provides the same type signature of compute in FaustDsp as I do for direct use.
I think this simplifies code significantly as vectors as well as slices can be used as arguments.
Additionally i change the type of the return value of get_num_input get_num_output methods.
The change implies some changes as the change makes FaustDsp lose its trait-object safty.
faust-state in rust-faust needs to be changed from a dyn box (dynamic dispatch) to a impl (static dispatch) as done here.