Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rust: FaustDsp trait improvements #1099

Open
wants to merge 1 commit into
base: master-dev
Choose a base branch
from

Conversation

crop2000
Copy link
Contributor

This PR has braking changes to the faust interface via the FaustDsp trait.
I provides the same type signature of compute in FaustDsp as I do for direct use.
I think this simplifies code significantly as vectors as well as slices can be used as arguments.
Additionally i change the type of the return value of get_num_input get_num_output methods.
The change implies some changes as the change makes FaustDsp lose its trait-object safty.
faust-state in rust-faust needs to be changed from a dyn box (dynamic dispatch) to a impl (static dispatch) as done here.

@crop2000 crop2000 force-pushed the faustdsp_trait_changes branch from e58b6f1 to 55ba284 Compare December 25, 2024 15:13
@crop2000
Copy link
Contributor Author

@bluenote10 can you have a look at this? it is a breaking change but I hope it doesn't make common ways usage impossible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant