cmd/go/internal/work: allow @ character in some -Wl, linker flags on darwin

[t0rr3sp3dr0]

The GNU linker interprets @file as "read command-line options from file".
Thus, we forbid values starting with @ on linker flags. However, this
causes a problem when targeting Darwin. @executable_path, @loader_path, and
@rpath are special values used in Mach-O to change the library search path
and can be used in conjunction with the -install_name and -rpath linker
flags. Since the GNU linker does not support Mach-O, targeting Darwin
implies not using the GNU linker. Therefore, we allow @ in the linker flags
if and only if cfg.Goos == "darwin".

Fixes #40559

[gopherbot]

This PR (HEAD: f72e4f8) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/638075.

Important tips:

• Don't comment on this PR. All discussion takes place in Gerrit.
• You need a Gmail or other Google account to log in to Gerrit.
• To change your code in response to feedback:
  • Push a new commit to the branch used by your GitHub PR.
  • A new "patch set" will then appear in Gerrit.
  • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
  • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
  • Multiple commits in the PR will be squashed by GerritBot.
• The title and description of the GitHub PR are used to construct the final commit message.
  • Edit these as needed via the GitHub web interface (not via Gerrit or git).
  • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
• See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

[gopherbot]

Message from Ian Lance Taylor:

Patch Set 1:

(1 comment)

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/638075.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Pedro Tôrres:

Patch Set 1:

(1 comment)

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/638075.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

This PR (HEAD: 8223b5c) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/638075.

Important tips:

• Don't comment on this PR. All discussion takes place in Gerrit.
• You need a Gmail or other Google account to log in to Gerrit.
• To change your code in response to feedback:
  • Push a new commit to the branch used by your GitHub PR.
  • A new "patch set" will then appear in Gerrit.
  • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
  • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
  • Multiple commits in the PR will be squashed by GerritBot.
• The title and description of the GitHub PR are used to construct the final commit message.
  • Edit these as needed via the GitHub web interface (not via Gerrit or git).
  • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
• See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

[gopherbot]

Message from Pedro Tôrres:

Patch Set 2:

(1 comment)

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/638075.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Ian Lance Taylor:

Patch Set 2: Commit-Queue+1

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/638075.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Go LUCI:

Patch Set 2:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2024-12-21T23:29:10Z","revision":"c5f2492f50988dcf4d493ce61e2750b531059351"}

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/638075.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Ian Lance Taylor:

Patch Set 2: -Commit-Queue

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/638075.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Go LUCI:

Patch Set 2:

This CL has failed the run. Reason:

Tryjob golang/try/gotip-linux-amd64-newinliner has failed with summary (view all results):

---

• go on master (change 638075)

Build or test failure, click here for results.

To reproduce, try gomote repro 8727899161809428689.

Additional links for debugging:

• Output for go tool dist test -json [shard 1]

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/638075.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Go LUCI:

Patch Set 2: LUCI-TryBot-Result-1

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/638075.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

This PR (HEAD: 25d06ff) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/638075.

Important tips:

• Don't comment on this PR. All discussion takes place in Gerrit.
• You need a Gmail or other Google account to log in to Gerrit.
• To change your code in response to feedback:
  • Push a new commit to the branch used by your GitHub PR.
  • A new "patch set" will then appear in Gerrit.
  • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
  • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
  • Multiple commits in the PR will be squashed by GerritBot.
• The title and description of the GitHub PR are used to construct the final commit message.
  • Edit these as needed via the GitHub web interface (not via Gerrit or git).
  • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
• See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

[gopherbot]

Message from Pedro Tôrres:

Patch Set 3:

(1 comment)

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/638075.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Ian Lance Taylor:

Patch Set 4: Commit-Queue+1

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/638075.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Go LUCI:

Patch Set 4:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2024-12-22T07:30:26Z","revision":"df8bd99aab450de7c0b5077a8192b610789150e2"}

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/638075.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Ian Lance Taylor:

Patch Set 4: -Commit-Queue

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/638075.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Go LUCI:

Patch Set 4:

This CL has passed the run

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/638075.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Go LUCI:

Patch Set 4: LUCI-TryBot-Result+1

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/638075.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Pedro Tôrres:

Patch Set 4:

(1 comment)

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/638075.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Ian Lance Taylor:

Patch Set 4: Auto-Submit+1 Code-Review+2 Commit-Queue+1

(1 comment)

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/638075.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Go LUCI:

Patch Set 4:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2024-12-22T23:57:09Z","revision":"df8bd99aab450de7c0b5077a8192b610789150e2"}

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/638075.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Ian Lance Taylor:

Patch Set 4: -Commit-Queue

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/638075.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Go LUCI:

Patch Set 4:

This CL has failed the run. Reason:

Tryjob golang/try/x_tools-gotip-linux-amd64 has failed with summary (view all results):

---

• go on master (change 638075)
• tools on master (commit ebeac1b)

Build or test failure, click here for results.

To reproduce, try gomote repro 8727806804236865889.

Additional links for debugging:

• Output for test golang.org/x/tools/gopls module

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/638075.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Go LUCI:

Patch Set 4: LUCI-TryBot-Result-1

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/638075.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Pedro Tôrres:

Patch Set 4:

(1 comment)

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/638075.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Ian Lance Taylor:

Patch Set 5: Commit-Queue+1

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/638075.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Go LUCI:

Patch Set 5:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2024-12-23T21:20:55Z","revision":"f0363c65898d98e1d545adfb47cdec5d119b708f"}

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/638075.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Ian Lance Taylor:

Patch Set 5:

(1 comment)

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/638075.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Ian Lance Taylor:

Patch Set 5: -Commit-Queue

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/638075.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Go LUCI:

Patch Set 5:

This CL has failed the run. Reason:

Tryjob golang/try/gotip-windows-386 has failed with summary (view all results):

---

• go on master (change 638075)

Build or test failure, click here for results.

To reproduce, try gomote repro 8727726037820195825.

Additional links for debugging:

• Output for go tool dist test -json [shard 4]

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/638075.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Go LUCI:

Patch Set 5: LUCI-TryBot-Result-1

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/638075.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Ian Lance Taylor:

Patch Set 5: Commit-Queue+1

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/638075.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Go LUCI:

Patch Set 5:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2024-12-23T22:04:13Z","revision":"f0363c65898d98e1d545adfb47cdec5d119b708f"}

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/638075.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Ian Lance Taylor:

Patch Set 5: -Commit-Queue

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/638075.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Go LUCI:

Patch Set 5:

This CL has passed the run

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/638075.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Go LUCI:

Patch Set 5: LUCI-TryBot-Result+1

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/638075.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Ian Lance Taylor:

Patch Set 5: Auto-Submit+1 Code-Review+2 Commit-Queue+1

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/638075.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Go LUCI:

Patch Set 5:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2024-12-23T23:31:40Z","revision":"f0363c65898d98e1d545adfb47cdec5d119b708f"}

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/638075.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Ian Lance Taylor:

Patch Set 5: -Commit-Queue

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/638075.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Go LUCI:

Patch Set 5:

This CL has passed the run

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/638075.
After addressing review feedback, remember to publish your drafts!