-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix remaining typescript issues, enable tsc
#32840
Conversation
There should be no "tsc" error now tested: dropzone, tribute, repo search (explore page) |
Those As for the |
I guess I will just uninstall |
Edit: Yes, it's passing, so this is ready. |
tsc
I switched back to
|
FYI I opened vitejs/vite-plugin-vue#487 regarding this |
So I think I found the magic incantation that requires the least amount of
This is a bit suboptimal as we do have a few node.js scripts, but we can likely split the tsconfig into two later, one for node files and one for |
I added type definitions for all named exports from Long-term, I'd like to forbid named exports from Vue SFCs, they just don't seem worth it when these functions can easily live outside. Should be possible with eslint. |
Fixes 79 typescript errors. Discovered at least two bugs in
notifications.ts
, and I'm pretty sure this feature was at least partially broken and may still be, I don't really know how to test it.After this, only like ~10 typescript errors remain in the codebase but those are harder to solve.