Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: don't log exception for every stale message #82553

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

perf: don't log exception for every stale message #82553

wants to merge 2 commits into from

Conversation

lynnagara
Copy link
Member

@lynnagara lynnagara requested review from a team as code owners December 24, 2024 00:01
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Dec 24, 2024
@codecov Codecov
Copy link

codecov bot commented Dec 24, 2024 •
edited
Loading

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
23385 1 23384 214
View the top 1 failed tests by shortest run time 
tests.sentry.consumers.test_dlq::test_dlq_stale_messages_timestamps[300]
Stack Traces | 0.683s run time 
#x1B[1m#x1B[.../sentry/consumers/test_dlq.py#x1B[0m:84: in test_dlq_stale_messages_timestamps
    strategy.submit(message)
#x1B[1m#x1B[.../sentry/consumers/dlq.py#x1B[0m:109: in submit
    raise InvalidMessage(
#x1B[1m#x1B[31mE   TypeError: InvalidMessage.__init__() got an unexpected keyword argument 'log_exception'#x1B[0m

To view more test analytics, go to the Test Analytics Dashboard
📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@lynnagara