Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(issue-views): Fold navigate behavior into issueViews context #82540

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

MichaelSun48
Copy link
Member

This PR refactors the issue views family of components by moving lots of the navigation logic into the IssueViews context created in this PR.

Many of the tab actions that were folded into the IssueViews context require changes to the query parameters, which is why it makes sense to combine these two actions in the reducer function. For example:

  • Duplicating a tab requires the newly created tab to be selected (change viewId parameter)
  • Discarding a tab's changes requires the query/sort to be reset to the original query/sort (change query/sort param

@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Dec 23, 2024
@MichaelSun48 MichaelSun48 marked this pull request as ready for review December 23, 2024 18:39
@MichaelSun48 MichaelSun48 requested a review from a team as a code owner December 23, 2024 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant