-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update rust to 1.82 #1587
base: master
Are you sure you want to change the base?
Conversation
I have a local version of this that I've rebased to current master and got the lints all sorted out but it still has a couple of test failures that are a bit concerning:
Why would the FRC42 method numbers be changed with this update? Aren't they supposed to be a stable hash value? |
They are supposed to be stable. I tested this because @raulk reported that 1.82 enables some wasm features we don't support in the FVM but... that shouldn't affect the tests here. |
Can you force-push your updated version? |
39dd71b
to
c530645
Compare
And explicitly disable features we don't support.
c530645
to
7b22a81
Compare
done .. and done again to match the new master from yesterday |
7b22a81
to
35069e4
Compare
Ah, ok. It's not computing the wrong number, it's calling the wrong function. We're expecting a call to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oooops .. is_none
, my bad
@@ -291,7 +291,7 @@ pub fn call_generic<RT: Runtime>( | |||
// this is how the EVM behaves. | |||
ContractType::Account | ContractType::NotFound => Ok(None), | |||
// If we're calling a "native" actor, always revert. | |||
ContractType::Native(_) => { | |||
ContractType::Native => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should probably keep the code CID and actually log it here.
IncorrectInputSize, | ||
// FVM precompile errors | ||
InvalidInput, | ||
CallForbidden, | ||
TransferFailed, | ||
VMError(ActorError), | ||
VMError, | ||
} | ||
|
||
impl From<ActorError> for PrecompileError { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd prefer to keep the error internals. I assume the complaint is that they're unused? In that case, we probably need to log them somewhere (will only affect actor debugging but it's still useful).
@Stebalien I've undone the dead code removals I originally pushed, one was easy to log, the other two I don't see an obvious place to log the output without either writing a new test just for that or spending more time that I have right now to figure out which tests might touch them and logging the specifics in there. Can you see a quick path to doing that, or should we just force override the linter on them? |
Clippy is a filthy liar. And it even tells us it's lying.
We log here:
|
This gets rid of the clippy warning, and will make actor debug logs a bit more readable.
I've improved this a bit. I adds a tiny bit of code bloat, but it shouldn't be noticeable. |
k, all lgtm, but maybe we should wait until after v16-final before merging. |
And explicitly disable features we don't support.