-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Adrian and Danny as FIP editors, remove Kaitlin #1095
base: master
Are you sure you want to change the base?
Conversation
I have included Danny and Adrian as new FIP Editors. I have also removed Kaitlin. FIP Editors should let me know if there is somewhere else I should be updating.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎅
@luckyparadise Someone needs to update the @filecoin-project/fips-editors github team and the @fip-editors slack group accordingly, but I don't have permissions to do so. |
I've created a peer PR for the repo permissions in filecoin-project/github-mgmt#92 |
As discussed in this thread, @luckyparadise It would be great if you could also update the FIP editor expectation to document that for PRs that change the protocol design/spec or considerations, FIP editors should make sure there exists at least two appropriate technical reviews & approvals before considering the PR is ready to merge. You can do it in a separate PR; I am raising it here so a record of the request exists. |
I have included Danny and Adrian as new FIP Editors and removed Kaitlin. FIP Editors should let me know if there is somewhere else I should be updating.