Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add atbash-cipher #586

Merged
merged 2 commits into from
Sep 23, 2024
Merged

Add atbash-cipher #586

merged 2 commits into from
Sep 23, 2024

Conversation

BNAndras
Copy link
Member

No description provided.

@BNAndras
Copy link
Member Author

Run locally, I don't see any changes to be made.

(base) ➜  atbash-cipher git:(add-atbash-cipher) dart format .
Formatted 2 files (0 changed) in 0.09 seconds.

As an aside, shouldn't a formatting check be separate from the testing of the solution? At the moment, it's a prerequisite before we test the example, but it might not have any bearing on the example. What if the formatting issue was in the stub, but not the example? I'd recommend either making a separate workflow for the formatting check (I've seen a few tracks do this) or make the formatter run after the tests pass.

@glennj
Copy link
Contributor

glennj commented Sep 23, 2024

Yeah, that's a good idea. Can you make an issue out of it?

@glennj glennj merged commit 07a8c93 into exercism:main Sep 23, 2024
3 checks passed
@BNAndras BNAndras deleted the add-atbash-cipher branch September 23, 2024 18:53
@BNAndras
Copy link
Member Author

See #591

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants