Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Test Envoy sync in PRs #813

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

ci: Test Envoy sync in PRs #813

wants to merge 1 commit into from

Conversation

phlax
Copy link
Member

@phlax phlax commented Oct 31, 2023

No description provided.

@phlax phlax marked this pull request as draft October 31, 2023 10:35
@phlax phlax mentioned this pull request Oct 31, 2023
Merged
@phlax phlax force-pushed the ci-envoy-sync branch 7 times, most recently from 0d9e9b6 to a044aeb Compare October 31, 2023 16:15
@phlax phlax changed the title [WIP] ci: Test Envoy sync in PRs ci: Test Envoy sync in PRs Oct 31, 2023
@phlax phlax marked this pull request as ready for review October 31, 2023 16:24
@phlax
ci: Test Envoy sync in PRs
7eab1b6 
Signed-off-by: Ryan Northey <[email protected]>
jpeach
jpeach approved these changes Nov 5, 2023
View reviewed changes
Copy link
Contributor

@jpeach jpeach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I vaguely get the gist of what this is doing, but explaining it all in comments in the workflow yaml would be pretty helpful :)

ci/sync_envoy.sh
commit_changes
if [[ -z "$NO_COMMIT_CHANGES" ]]; then
commit_changes
fi
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While you are here, remove the unused GO_TARGETS and IMPORT_BASE variables?

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 5, 2023

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@github-actions github-actions bot added the stale label Dec 5, 2023
@github-actions GitHub Actions
Copy link

This pull request has been automatically closed because it has not had activity in the last 37 days. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@github-actions github-actions bot closed this Dec 12, 2023
@phlax phlax reopened this Dec 12, 2023
@phlax
Copy link
Member Author

phlax commented Dec 12, 2023

apologies for delay - i will follow up on this - just been busy with some other stuff

@github-actions github-actions bot removed the stale label Dec 12, 2023
@github-actions GitHub Actions
Copy link

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@github-actions github-actions bot added the stale label Jan 11, 2024
@phlax phlax added no stalebot and removed stale labels Jan 11, 2024
@phlax
Copy link
Member Author

phlax commented Jan 11, 2024

ill come back to this once envoy release is out of the way

@alecholmez
Copy link
Contributor

@jpeach wanna try and get this in?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpeach jpeach jpeach approved these changes

Assignees

@jpeach jpeach

Labels
no stalebot
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@phlax @alecholmez @jpeach