Make parameter and objective classes slotted #74
+17
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note: there was another issue which messed with our subclass detection mechanism, which has already be resolved but the fix has not yet been released. However, the checks should automatically pass once attrs |
AVHopp
approved these changes
Jan 8, 2024
Scienfitz
reviewed
Jan 8, 2024
Scienfitz
approved these changes
Jan 8, 2024
Scienfitz
added
the
on hold
AdrianSosic
force-pushed
the
feature/slotted_parameters
branch
from
8d645aa to
4b98c3f
Compare
|
@AVHopp @Scienfitz, FYI: I rebased and added one more commit since in the meantime we also had to make our |
AdrianSosic
changed the title
AdrianSosic
removed
the
on hold
AdrianSosic
force-pushed
the
feature/slotted_parameters
branch
from
4b98c3f to
3a33fda
Compare
AdrianSosic
force-pushed
the
feature/slotted_parameters
branch
from
3a33fda to
a3e527c
Compare
AdrianSosic
force-pushed
the
feature/slotted_parameters
branch
from
a3e527c to
6437b75
Compare
AdrianSosic
force-pushed
the
feature/slotted_parameters
branch
from
6437b75 to
0d2e7e8
Compare
AVHopp
reviewed
Aug 13, 2024
|
Again on hold until the following blocking issue gets resolved: |
AdrianSosic
added
the
on hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that
attrs==24.1.0supportscached_propertywith slotted classes, we can finally enable slots for our parameter and objective classes.