Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add fluent usage documentation #10051

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Add fluent usage documentation #10051

wants to merge 4 commits into from

Conversation

dipeshmsft
Copy link
Member

@dipeshmsft dipeshmsft commented Nov 11, 2024 •
edited by dotnet-policy-service bot
Loading

Microsoft Reviewers: Open in CodeFlow

@dipeshmsft dipeshmsft requested review from a team as code owners November 11, 2024 13:14
@dotnet-policy-service dotnet-policy-service bot added the PR metadata: Label to tag PRs, to facilitate with triage label Nov 11, 2024
@miloush
Copy link
Contributor

miloush commented Nov 11, 2024 •
edited
Loading

I think it needs to be more prominently written that this is all experimental for testing purposes and might not work the same in the final release of the theming.

This specifically includes the idea of merging in a dictionary, thus all the resource keys and the way they are referenced.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miloush miloush miloush left review comments

@riverar riverar riverar left review comments

@singhashish-wpf singhashish-wpf Awaiting requested review from singhashish-wpf

At least 1 approving review is required to merge this pull request.

Assignees

@dipeshmsft dipeshmsft

Labels
PR metadata: Label to tag PRs, to facilitate with triage Win 11 Theming
Projects
WPF Fluent Theming
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dipeshmsft @miloush @riverar @HotCakeX