Made changes in test repo for making Setter.Value the ContentProperty for Setter #321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anjali-wpf
changed the title
singhashish-wpf
requested changes
Jul 10, 2024
| @@ -71,6 +71,7 @@ | |||
| <PropertyToSkip PropertyName="LCID" Owner="CultureInfo" /> | |||
| <!-- With DWM turned on, Button.BorderBrush changes--> | |||
| <PropertyToSkip PropertyName="BorderBrush" Owner="Button" /> | |||
| <PropertyToSkip PropertyName="Value" Owner="Setter" /> | |||
There was a problem hiding this comment.
I would like to understand how we are using the PropertiesToSkip.xaml to skip the properties for the comparison and why are we making a change here. The rationale for the question is that we were checking it earlier and now we are skipping this check, so skipping needs better reasoning.
| @@ -301,6 +303,59 @@ private static bool CompareXmlNode(XmlNode node1, XmlNode node2) | |||
| return true; | |||
| } | |||
|
|
|||
| private static bool IsContentProperty(XmlNode xmlNode) | |||
There was a problem hiding this comment.
I am not getting the implementation of this function. As of now what I can get is that we are reading the propertiesToSkip.xml and working on that check only. There should be more checks in my understanding to validate if it is a ContentProperty or not.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Issue #84
Description
Made changes in test repo for making Setter.Value the ContentProperty for Setter
Customer Impact
None
Regression
None
Testing
Added test case
Risk
NA
Microsoft Reviewers: Open in CodeFlow