Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactored version-switcher.js #1841

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Refactored version-switcher.js #1841

wants to merge 1 commit into from
+7 −30

Conversation

adamzap
Copy link
Member

@adamzap adamzap commented Dec 21, 2024

  • Simplified code
  • Stopped using jQuery
  • Moved refactored code to djangoproject.js

This patch should bring no user-facing changes.

Refs #1827

To test this:

  1. Navigate to a documentation page
  2. Click on a paragraph marker to add a fragment identifier to your current URL (like #getting-help)
  3. Click on a different documentation version via the floating element
  4. Verify that the fragment identifier persisted to the new documentation URL

@adamzap
Refactored version-switcher.js
f77f88e 
- Simplified code
- Stopped using jQuery
- Moved refactored code to `djangoproject.js`

This patch should bring no user-facing changes.

Refs django#1827
pauloxnet
pauloxnet approved these changes Dec 21, 2024
View reviewed changes
Copy link
Member

@pauloxnet pauloxnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pauloxnet pauloxnet pauloxnet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adamzap @pauloxnet