refactor(Emoji)!: make imageURL() changing extension dynamically #10613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
kyranet
previously requested changes
Dec 9, 2024
Co-authored-by: Aura <[email protected]>
almeidx
approved these changes
Dec 21, 2024
almeidx
reviewed
Dec 21, 2024
| @@ -46,7 +46,7 @@ class Emoji extends Base { | |||
| * @returns {?string} | |||
| */ | |||
| imageURL(options) { | |||
| return this.id && this.client.rest.cdn.emoji(this.id, options); | |||
| return this.id && this.client.rest.cdn.emoji(this.id, this.animated ? { extension: 'gif', ...options } : options); | |||
There was a problem hiding this comment.
Actually, while this works, it might be worth adding support for the forceStatic option like the other dynamic image URL methods
You'd have to change the parameter type to ImageURLOptions and handle the forceStatic option here as well
There was a problem hiding this comment.
what about adding an animated option for the emoji function in /rest?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
I think it'd be better if
Emoji#imageURL()changes the extension dynamically as others...URL()functions.Status and versioning classification: