Add nodebb service #4624
Open
Add nodebb service #4624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peaklabs-dev
requested changes
Dec 19, 2024
templates/compose/nodebb.yaml
Outdated
| source: ./.docker/config/setup.json | ||
| target: /usr/src/app/setup.json | ||
| isDirectory: false | ||
| content: | |
There was a problem hiding this comment.
Please use env variables or better our magic variables and do not hardcode secrets.
There was a problem hiding this comment.
NodeBB sadly doesn't have any listed documentation that I can find that uses environment variables. And they require the existence of setup.json. I don't know if this is a problem fully but I created a new entrypoint that overwrites the existing setup.json with the magic variables.
peaklabs-dev
added
⚙️ Service
peaklabs-dev
removed
the
💤 Waiting for changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes