Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: real preview URL example #3900

Draft
wants to merge 1 commit into
base: next
Choose a base branch
from

Conversation

KaelWD
Copy link
Contributor

@KaelWD KaelWD commented Oct 12, 2024

Changes

  • Domain preview replaces {{pr_id}} and {{random}} not just {{domain}}
  • Live updates
  • {{random}} is now the same value for all URLs
  • Refactored 4 different implementations to all use the same get_preview_fqdn function.

Screenshot_20241012_223341

Remaining tasks:

  • Make sure all the other generate_preview_fqdn methods still work correctly

@peaklabs-dev peaklabs-dev added the 🛠️ Feature Issues requesting a new feature. label Oct 14, 2024
@peaklabs-dev
Copy link
Member

@KaelWD are you still working on this?

@peaklabs-dev peaklabs-dev added the 💤 Waiting for feedback Issues awaiting a response from the author. label Nov 15, 2024
@KaelWD
Copy link
Contributor Author

KaelWD commented Nov 15, 2024

I probably won't get around to finishing it this week, you're welcome to push to my branch though if you really want to get it in. I was kinda hoping my actually important changes would be reviewed before this one: #3845 + #4067

@peaklabs-dev peaklabs-dev removed the 💤 Waiting for feedback Issues awaiting a response from the author. label Nov 19, 2024
@peaklabs-dev
Copy link
Member

Alright, the other PRs have been merged, if you have no time to work on it let me know so I can close this PR otherwise it would be awesome if you could make it work as I really like the change.

@peaklabs-dev peaklabs-dev added the 💤 Waiting for changes PRs awaiting changes from the author. label Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🛠️ Feature Issues requesting a new feature. 💤 Waiting for changes PRs awaiting changes from the author.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants