Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When the audio play done, the event key should be cleanup. #17908

Open
wants to merge 1 commit into
base: v3.8.6
Choose a base branch
from

Conversation

yoki0805
Copy link
Contributor

Issue 17590

The id is an incrementing number.
It makes the number of key in evenetTarget._callbackTable bigger.

Test project:
snd-test.zip

Changelog


Continuous Integration

This pull request:

  • needs automatic test cases check.

    Manual trigger with @cocos-robot run test cases afterward.

  • does not change any runtime related code or build configuration

    If any reviewer thinks the CI checks are needed, please uncheck this option, then close and reopen the issue.


Compatibility Check

This pull request:

  • changes public API, and have ensured backward compatibility with deprecated features.
  • affects platform compatibility, e.g. system version, browser version, platform sdk version, platform toolchain, language version, hardware compatibility etc.
  • affects file structure of the build package or build configuration which requires user project upgrade.
  • introduces breaking changes, please list all changes, affected features and the scope of violation.

When the audio play done, the event key should be cleanup.
Copy link

⚠️ Package size ⤴ 36 bytes, old: 5376038, new: 5376074

Interface Check Report

This pull request does not change any public interfaces !

@minggo minggo requested a review from bofeng-song December 25, 2024 02:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants